Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Tabulate package versions in core #5985

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Conversation

stefangordon
Copy link
Contributor

In #3313 Tabulate was pinned to 0.7.7. Pinning to this older version creates installation challenges and general irritation for users.

I understand the way the tests are written it is currently helpful to minimize change in this package, but I have verified that TestCoreCLIOutput tests work with all versions between 0.7.7 and 0.8.2 (latest) - so we can at least expand dependencies to that range.

@promptws
Copy link

promptws commented Apr 2, 2018

View a preview at https://prompt.ws/r/Azure/azure-cli/5985
This is an experimental preview for @microsoft users.

@derekbekoe
Copy link
Member

@stefangordon Can you provide some info on how you are attempting to install the CLI?
I assume pip? A virtual environment could be used to separate the dependencies between your multiple projects.
We can still accept this change but would like to know if it's preventing you from a certain scenario.

@stefangordon
Copy link
Contributor Author

stefangordon commented Apr 2, 2018

Hey @derekbekoe -
The immediate issue for me is some work we are doing with http://github.com/capitalone/cloud-custodian to extend it to support Azure. Custodian is a CLI for working with cloud resources too, and we have some neat integration with Azure-cli we are building, but the Tabulate version is a problem for us. It seemed this change to CLI was the best approach since it improves CLI usability as well.

But even in typical use cases, I have several times had to switch into a virtualenv or conda environment to run the Azure CLI due to this package, or at least had to manually resolve the dependency with a pip install tabulate==0.7.7 when a downgrade was necessary.

@derekbekoe
Copy link
Member

I've taken a look at the release notes since 0.7.7 and it's mostly bug fixes.
https://bitbucket.org/astanin/python-tabulate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants