Update droid build script #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5687 |
derekbekoe
approved these changes
Feb 27, 2018
|
|
||
| title 'Push docker image as latest' | ||
| if [ "$TRAVIS" == "true" ]; then | ||
| docker tag $image_name azureclidev.azurecr.io/azurecli-test-$image_owner:latest |
There was a problem hiding this comment.
Docker tag would not actually push it.
I assume the push happens elsewhere?
There was a problem hiding this comment.
You got me. Fixed in a newer commit.
1. Reflect the a01 droid drop path change 2. Tag the image to latest in Travis build 3. Using ADD command to pull a01droid executable in Dockerfile instead of script.
derekbekoe
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of script.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)