Skip to content

Conversation

@derekbekoe
Copy link
Member

This PR is in response to Azure/msrest-for-python#86

@promptws
Copy link

View a preview at https://prompt.ws/r/Azure/azure-cli/5596
This is an experimental preview for @microsoft users.

@derekbekoe
Copy link
Member Author

@lmazuel What's the best way to verify this change?

@derekbekoe derekbekoe changed the title Enable HTTP logger Enable HTTP logger after msrest change Feb 15, 2018
@lmazuel
Copy link
Member

lmazuel commented Feb 15, 2018

If you mean CLI unittests, I don't think you can :/. If really you want to do it, I would use a assertLog tests, something like this:
https://github.com/Azure/msrest-for-python/blob/b79de4259d99eb46878ae17255bb3667df08bdd9/tests/test_serialization.py#L1986-L2006

If you mean manually test it on your local machine, install msrest from the branch of the PR and --debug should show HTTP logs exactly like now.

@derekbekoe
Copy link
Member Author

I wanted to verify manually and just have 👍

@lmazuel
Copy link
Member

lmazuel commented Feb 15, 2018

Do you have an estimated release date for this CLI core? This way I merge the msrest one after new cli-core is out, and no disruption for users.

@derekbekoe
Copy link
Member Author

derekbekoe commented Feb 15, 2018

We'll publish on 2/27.
That's the current plan anyway.

@derekbekoe
Copy link
Member Author

@lmazuel Can you 'approve' this if it looks good then I can merge.

@derekbekoe derekbekoe merged commit a23636d into Azure:dev Feb 21, 2018
@derekbekoe derekbekoe deleted the http-logger branch February 21, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants