-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webapp: fix broken 'log' and 'zip deployment' commands #5335
Conversation
View a preview at https://prompt.ws/r/Azure/azure-cli/5335 |
from ._validators import WEB_APP_TYPES | ||
return _list_app(cmd.cli_ctx, WEB_APP_TYPES, resource_group_name) | ||
result = _list_app(cmd.cli_ctx, resource_group_name) | ||
return [r for r in result if 'function' not in r.kind] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very accurate now, but still good enough to filter away the functionapp
, while still captures all the rest.
With all those unannounced backend changes on app-kind
, it is no longer worthwhile for client sides to be accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the regressions caused by my merge.
Fix #5332
Also, address comments made on #4890 by loosening the app-kind check
General Guidelines
Command Guidelines
(see Authoring Command Modules)