Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webapp: fix broken 'log' and 'zip deployment' commands #5335

Merged
merged 6 commits into from
Jan 18, 2018
Merged

webapp: fix broken 'log' and 'zip deployment' commands #5335

merged 6 commits into from
Jan 18, 2018

Conversation

yugangw-msft
Copy link
Contributor

@yugangw-msft yugangw-msft commented Jan 18, 2018 •
edited
Loading

Fix #5332
Also, address comments made on #4890 by loosening the app-kind check

General Guidelines

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@promptws
Copy link

View a preview at https://prompt.ws/r/Azure/azure-cli/5335
This is an experimental preview for @microsoft users.

yugangw-msft
yugangw-msft commented Jan 18, 2018
View reviewed changes
src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/custom.py Outdated
from ._validators import WEB_APP_TYPES
return _list_app(cmd.cli_ctx, WEB_APP_TYPES, resource_group_name)
result = _list_app(cmd.cli_ctx, resource_group_name)
return [r for r in result if 'function' not in r.kind]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very accurate now, but still good enough to filter away the functionapp, while still captures all the rest.
With all those unannounced backend changes on app-kind, it is no longer worthwhile for client sides to be accurate

panchagnula
panchagnula approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the regressions caused by my merge.

@yugangw-msft yugangw-msft merged commit 4a46eab into Azure:dev Jan 18, 2018
@yugangw-msft yugangw-msft deleted the app branch January 18, 2018 07:24
This was referenced Jan 18, 2018
Closed
Closed
@josalem josalem mentioned this pull request Jan 18, 2018
Closed
@yugangw-msft yugangw-msft mentioned this pull request Jan 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panchagnula panchagnula panchagnula approved these changes

Assignees

@panchagnula panchagnula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yugangw-msft @promptws @panchagnula