Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg_resources instead of pip internal methods #5252

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

derekbekoe
Copy link
Member

pip is moving it's internal methods to be private in the future so we should no longer rely on them.
https://pip.pypa.io/en/latest/user_guide/#using-pip-from-your-program


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • [n/a] Each command and parameter has a meaningful description.
  • [n/a] Each new command has a test.

(see Authoring Command Modules)

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5252
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

@derekbekoe derekbekoe added Container Registry az acr Core CLI core infrastructure and removed Container Registry az acr labels Jan 9, 2018
Modify version and history

Explicitly call list to make pylint happy
@derekbekoe
Copy link
Member Author

Marked as DNM whilst I do some verification with the different installers.

@derekbekoe
Copy link
Member Author

Verified.

@derekbekoe derekbekoe merged commit 655af11 into Azure:dev Jan 9, 2018
@derekbekoe derekbekoe deleted the no-pip-imports branch January 9, 2018 21:28
@haroldrandom haroldrandom added the Core CLI core infrastructure label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core CLI core infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants