Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable CI PR check for versions if repo is Azure/azure-cli #5225

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

derekbekoe
Copy link
Member

No description provided.

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5225
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

@derekbekoe derekbekoe added this to the Sprint 29 milestone Jan 8, 2018
@derekbekoe derekbekoe changed the title Check CI version checking still runs as expected Re-enable CI PR check for versions if repo is Azure/azure-cli Jan 8, 2018
@derekbekoe
Copy link
Member Author

@tjprescott It wasn't enabled for PRs before. It is now.

@@ -13,7 +13,8 @@ azdev verify document-map
echo "Verify readme history"
python -m automation.tests.verify_readme_history

if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then
# Only verify package version or PRs to Azure/azure-cli (not other forks)
if [ $TRAVIS_EVENT_TYPE == "pull_request" ] && [ $TRAVIS_REPO_SLUG == "Azure/azure-cli" ]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troydai You had the quotes before around the $TRAVIS_PULL_REQUEST but I don't think it is needed?

@derekbekoe derekbekoe merged commit 6d82763 into Azure:dev Jan 8, 2018
@derekbekoe derekbekoe deleted the should-fail-v-check branch January 8, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants