Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify custom client_arg_name #5139

Merged
merged 3 commits into from
Dec 20, 2017

Conversation

derekbekoe
Copy link
Member

For vendored SDKs, the dynamic smartness of client_arg_name = 'client' if operation.startswith(('azure.cli', 'azext')) else 'self' is not reliable.

This PR allows the user to override this.

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5139
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

@derekbekoe
Copy link
Member Author

@tjprescott In my specific case, there's an extension that has it's SDK under azext_NAME and the CLI was choosing client when I wanted self.

@derekbekoe derekbekoe merged commit 6808e6b into Azure:KnackConversion Dec 20, 2017
@derekbekoe derekbekoe deleted the custom-client-arg branch December 20, 2017 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants