[Knack] Monitor module conversion. #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5125 |
yugangw-msft
approved these changes
Dec 18, 2017
| @@ -0,0 +1,7 @@ | |||
| {apiVersion: v1, clusters: [{cluster: {certificate-authority-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUV4ekNDQXErZ0F3SUJBZ0lRRnF1aU55NWZrRkRpQTZjWENIZWhuakFOQmdrcWhraUc5dzBCQVFzRkFEQU4KTVFzd0NRWURWUVFERXdKallUQWVGdzB4TnpFeE1qY3hOelE1TWpkYUZ3MHhPVEV4TWpjeE56UTVNamRhTUEweApDekFKQmdOVkJBTVRBbU5oTUlJQ0lqQU5CZ2txaGtpRzl3MEJBUUVGQUFPQ0FnOEFNSUlDQ2dLQ0FnRUF4a3BqCm9hdGJXcHdQUnY3MGlPSDVmdFdDaHVpZFpIczdmK2Y1SU1ZandSa1pNeHQwaVR2NUxxRVgxb1VxaElPVEphQU4KMmdyYTJ3SHAwa3BNcFBtaXhwRjFTSkNQZm52UkVTOUYwTFBrN2tkZUNJRzBiRjE4VU43b0tyMGI5c0JIUll1QQphNVd6ak0vSlhPa2FxOUJyMVFjU2EzWW5Sb2w3cEduNmJRVXBHbW9EMnhwYzZKdVVRK25CeldhdERHeEQ2YVZ1CnVhWGVQL3phZEZQTlk3L0o0ZHVmUmZwdXh6eHpEYTBKTW4wQkpxOFFMb25HSktQL2ZBaTNYdmVCbHdXRU54QTcKd1E0RGlXeXhYMTN5bzdpR2FjeUpBVEZSRHkxK2I1QlB4R0ZyVzQ4Q3Vqd0xBUHBacjM4YjVRM1hUVVF1bm4yawpwK0I4RlJWd09FZTh0VHBwd3ZCcjlPSFRSU3hRZjdZUHpEaEQ4dVdCZHovS3NxRVZ5K3lpOExTOTVBbVVGclh6ClNyUjJLR0Vic1lUQ3RKMEpBMDJ1Wkw0N3N6UmtocmNWb3BXdmZ6blJYVkZUZFZsTUhCVzNwK2RDMmR4eGlBODIKMmR3VExKZkFETE5rSDR1MDdVeWNzY0hrMUZwYm9rUkRVbW1udXZQM2JjVTVuYnpwV0d5dUxzRmN4V2VzSkN6aQppNnpHQ0dvaUZZSUJWeHFxWGliL1JuNkJYZnFYSlE4YjE5dFRSOEgrdHQvN3NDT084UVhJS3pIcXMxVEtGMVU3CjBRQmk3VGhZZ2FmSnVoWjFLaThMU0h5MUY4UzhPMVhoclF4eWN5eUN4SHEycE4wYzBQUGZNRlNuOVNmRUpocE4KS0ZFYkpLbHcvMkpLanlpenVod2dWR1JTWDF2MGd0ajRncGNxSGtFQ0F3RUFBYU1qTUNFd0RnWURWUjBQQVFILwpCQVFEQWdLa01BOEdBMVVkRXdFQi93UUZNQU1CQWY4d0RRWUpLb1pJaHZjTkFRRUxCUUFEZ2dJQkFEODlOOVIxCjZsMU1ZblB6UytJNzNsTUd4K09MNTk3S0pvemcrZ1kwdGFJcHppaXZxc2RnSktrRHZwZTZBY0pxcU05ZWphbkEKUWxha2RYS1I3MHIrNFhycXgzdXg4OElLVjhibExmWVJxeEp0UWNJREoyZ1JSMWxLdC9XZXRGMVRKRmpPTFg1SgplSVl5VnZYalE2UldqTW8ySTdIbXVETXJmUk9QMndHdndPLzcxeVppZWlqQlNGdHIzSkZzK1pEWmlqSjZTV0dwCncyUmJocTVlRSs4MS9ZSVNxYXdLUk5wc2VIVkRQYktFQ3UvT0FFQzhjOG9NU0NHWWs3UThlRUh3RnlGenJSblMKM2pGM1BXM21tdTJQNElQSG5RMkNMbjFvSU1Sc3o1a2tjNUFQNTBCcUNBdTdMSDRsakRBdjBFakNYaGxCTndPWQpmbUtyNWxSalJpM1BRL3NYc3U0NXpWUXZhdjNoZGdWeGtCSXlHWTdEMldqbllEVkdnU2hsY0R3b1EwRWdxWWJ1Ck1mOWZrRkZNdWd0cUNKUUk5QUh0QXMzbzBBRGNvZ1BISTRnckJPN1hlMGM4TVhodDc2YmdvWGZFNlMrVDZ1WUIKWFNLRHNqYldKWGhla3dGQW9IbVNaTjJBb0EvaXg2Mkp5UG9HL0RaWGFoQ1h4dWdHc2tnOWZweERzQzUxbVgwcgp4OW9BTWs1M20xTkVoSjhhY1lFQ28yQXorRUxQcCtZUFBZdHVQU1Z4S2JlNFc0ZDZWSlR2K1ljc25aZWpuamZsCjFPVTdjOGRqQzNDYUVDaHZtUDQ2eFRHeXpmZmRmVWx5dS9DM2p5ZEx6Ny9yQytaWUZBOFozNFRBMHZFYWFUVUEKSEZvd0lFQ3pGV2FiZ0k3RTcyQ3dpYWhoWkpuUmFkV2F0dG5SCi0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K, | |||
There was a problem hiding this comment.
Appears a testing file which we should remove
| @@ -244,4 +224,4 @@ def _get_alert_settings(client, resource_group_name, activity_log_alert_name, th | |||
| else: | |||
| return None | |||
| else: | |||
| raise CLIError(ex.message, ex) | |||
| raise CLIError(ex.message) | |||
There was a problem hiding this comment.
We probably should cross check for why the CLIError no loner accepts inner exception object
There was a problem hiding this comment.
CLIError as defined in the old core:
class CLIError(Exception):
passAs defined in Knack:
class CLIError(Exception):
def __init__(self, message):
super(CLIError, self).__init__(message)So the reason is because Knack overrides the init and doesn't accept the same arguments. @derekbekoe is there a reason Knack does this?
There was a problem hiding this comment.
I don't see a reason why we can't just inherit from Exception like before.
Created microsoft/knack#65 to fix this.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4938. Tests will be re-enabled in subsequent PR.