Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BatchAI] BatchAI module Knack conversion #5120

Merged
merged 3 commits into from
Dec 18, 2017
Merged

[BatchAI] BatchAI module Knack conversion #5120

merged 3 commits into from
Dec 18, 2017

Conversation

tjprescott
Copy link
Member

Implements #4925. Tests to be re-enabled in future PR.

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5120
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

@AlexanderYukhanov
Copy link
Contributor

The changes look fine to me. Is it already runnable, can I test it?

@derekbekoe
Copy link
Member

@AlexanderYukhanov You should be able to visit https://prompt.ws/r/Azure/azure-cli/5120 to try it out! It takes a few mins to load your instance.

Copy link
Member

@derekbekoe derekbekoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the .flake8 file?

@derekbekoe
Copy link
Member

derekbekoe commented Dec 15, 2017

$ az batchai cluster create -h

Command
    az batchai cluster create: Create a cluster.

Arguments
    --name -n        [Required]: Name of the cluster.
    --resource-group [Required]

RG has no description.

Same with some other commands such as:
az batchai cluster list -h
az batchai cluster resize -h
az batchai cluster auto-scale -h

@AlexanderYukhanov
Copy link
Contributor

the help string for resource-group is missing from every command

@AlexanderYukhanov
Copy link
Contributor

and '-g' now doesn't work

@tjprescott
Copy link
Member Author

Thanks @AlexanderYukhanov, I fixed the issue with resource group.

@tjprescott tjprescott merged commit 883e96d into Azure:KnackConversion Dec 18, 2017
@tjprescott tjprescott deleted the BatchAiConversion branch December 18, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants