DataLake Knack conversion #5100
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5100 |
| recording_processors=_merge_lists(default_recording_processors, recording_processors), | ||
| replay_processors=_merge_lists(default_replay_processors, replay_processors), | ||
| recording_patches=_merge_lists(default_recording_patches, recording_patches), | ||
| replay_patches=_merge_lists(default_replay_patches, replay_patches), |
There was a problem hiding this comment.
Prev. it was or. Now you are merging.
Is this intended and do we want to support merging?
There was a problem hiding this comment.
Yes, this was very intended. The only reason is was "or" for so long was because no one ever tried to use it... we just always added any processors we needed to the core testbase (which isn't really a good idea...)
| @@ -172,7 +172,7 @@ def load_command_table(self, _): | |||
| # Resource feature commands | |||
| if self.supported_api_version(min_api='2017-05-10'): | |||
| feature_table_transform = '{Name:name, RegistrationState:properties.state}' | |||
| with self.command_group('feature', resource_feature_sdk) as g: | |||
| with self.command_group('feature', resource_feature_sdk, client_factory=cf_features) as g: | |||
There was a problem hiding this comment.
Why this change?
If it is needed, I guess you can remove client_factory=cf_features below?
There was a problem hiding this comment.
Yeah, pretty much so I could remove the kwarg in the lines below.
…ure-cli into DataLakeConversion
Implements #4931 and #4932.
Tests not included as part of CI as there are some issues with some of them (possibly service flakiness).