IoT module knack conversion #5084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5084 |
derekbekoe
commented
Dec 12, 2017
Member
Author
There was a problem hiding this comment.
@troydai I added this back in. Looks like it was missed from the prev. vcr_test_base
Add CI Re-record tests Use actual value in checkers
derekbekoe
force-pushed
the
knack-iot
branch
from
b5a0c9f to
dcedbcb
Compare
digimaun
approved these changes
Dec 13, 2017
|
|
||
|
|
||
| @Completer | ||
| def get_device_id_completion_list(cmd, prefix, namespace): # pylint: disable=unused-argument |
Member
There was a problem hiding this comment.
I know this device completer was here before...but I'd like to note that it isn't that valuable. The device list endpoint returns up to 1000 devices, and you could have a million+ devices on an IoT Hub.
Member
There was a problem hiding this comment.
Device CRUD commands would be deprecated in favor of IoT extension equivalents anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@digimaun Please review. You can use the prompt.ws service below to do some ad-hoc testing of the commands (It takes 2/3 minutes to load so refresh the page afterwards).