Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knack Conversion for consumption module #5082

Merged
merged 4 commits into from
Dec 12, 2017
Merged

Knack Conversion for consumption module #5082

merged 4 commits into from
Dec 12, 2017

Conversation

williexu
Copy link
Contributor

Closes #4928

-changed tests to record-only

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5082
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

@williexu williexu changed the base branch from dev to KnackConversion December 11, 2017 18:56
tjprescott
tjprescott suggested changes Dec 11, 2017
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, and please verify the commands work, but LGTM.

src/command_modules/azure-cli-consumption/azure/cli/command_modules/consumption/_params.py Outdated
c.argument('include_meter_details', options_list=('--include-meter-details', '-m'), action='store_true', help='include meter details in the usages')
c.argument('start_date', options_list=('--start-date', '-s'), type=get_datetime_type(), help='start date (in UTC Y-m-d) of the usages. Both start date and end date need to be supplied or neither')
c.argument('end_date', options_list=('--end-date', '-e'), type=get_datetime_type(), help='end date (in UTC Y-m-d) of the usages. Both start date and end date need to be supplied or neither')
c.argument('billing_period_name', options_list=('--billing-period-name', '-p'), help='name of a specific billing period to get the usage details that associate with')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert the tuple syntax for options_list to list syntax.

@williexu
Copy link
Contributor Author

Just manually checked the commands on my own subscription, and they work perfectly. Tests were changed to record_only() since start_date/end_date/billing_period arguments vary between subscriptions (and some subscriptions dont support consumption). Tests can be run live provided a supported subscription is used and the tests are changed to reflect the right dates/periods.

@tjprescott addressed your comment

@tjprescott
Copy link
Member

Looks good. Just get the CI green :)

@tjprescott tjprescott merged commit 2be3f2f into Azure:KnackConversion Dec 12, 2017
@tjprescott tjprescott mentioned this pull request Dec 14, 2017
Closed
@williexu williexu deleted the consumption branch July 11, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williexu @azuresdkci @tjprescott