-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knack Conversion for consumption module #5082
Conversation
View a preview at https://prompt.ws/r/Azure/azure-cli/5082 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change, and please verify the commands work, but LGTM.
c.argument('include_meter_details', options_list=('--include-meter-details', '-m'), action='store_true', help='include meter details in the usages') | ||
c.argument('start_date', options_list=('--start-date', '-s'), type=get_datetime_type(), help='start date (in UTC Y-m-d) of the usages. Both start date and end date need to be supplied or neither') | ||
c.argument('end_date', options_list=('--end-date', '-e'), type=get_datetime_type(), help='end date (in UTC Y-m-d) of the usages. Both start date and end date need to be supplied or neither') | ||
c.argument('billing_period_name', options_list=('--billing-period-name', '-p'), help='name of a specific billing period to get the usage details that associate with') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert the tuple syntax for options_list
to list syntax.
Just manually checked the commands on my own subscription, and they work perfectly. Tests were changed to record_only() since @tjprescott addressed your comment |
Looks good. Just get the CI green :) |
f679860
to
d5e3b45
Compare
Closes #4928
-changed tests to record-only