Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run --help on all commands in CI task #4327

Merged
merged 2 commits into from
Aug 28, 2017

Conversation

derekbekoe
Copy link
Member

@derekbekoe derekbekoe commented Aug 28, 2017

Closes #4224

This change also speeds up our CI jobs as it executes the two main tasks in parallel.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@codecov-io
Copy link

Codecov Report

Merging #4327 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4327   +/-   ##
======================================
  Coverage      70%     70%           
======================================
  Files         475     475           
  Lines       29919   29919           
  Branches     4627    4627           
======================================
  Hits        20945   20945           
+ Misses       7490    7486    -4     
- Partials     1484    1488    +4
Impacted Files Coverage Δ
...dback/azure/cli/command_modules/feedback/custom.py 31.25% <0%> (ø) ⬆️
...nent/azure/cli/command_modules/component/custom.py 16.26% <0%> (ø) ⬆️
...li-cloud/azure/cli/command_modules/cloud/custom.py 13.79% <0%> (ø) ⬆️
src/azure-cli-core/azure/cli/core/util.py 69.73% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d67155...2646b58. Read the comment docs.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tjprescott
Copy link
Member

I believe this should fix #4224, right @derekbekoe ?

@derekbekoe
Copy link
Member Author

Thanks yes it does. Added to PR desc.

@derekbekoe derekbekoe merged commit e99f4da into Azure:master Aug 28, 2017
@derekbekoe derekbekoe deleted the try-ci-run-help branch August 28, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants