[ACS] format default dns_name_prefix #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjtsdl, |
|
fix #4116 |
added 2 commits
August 16, 2017 12:15
rjtsdl
force-pushed
the
jiren-formatdnsprefix
branch
from
cff495b
to
3648377
Compare
|
@anhowe TAL |
Codecov Report
@@ Coverage Diff @@
## master #4237 +/- ##
==========================================
+ Coverage 70.05% 70.05% +<.01%
==========================================
Files 475 475
Lines 29605 29612 +7
Branches 4539 4540 +1
==========================================
+ Hits 20739 20746 +7
Misses 7419 7419
Partials 1447 1447
Continue to review full report at Codecov.
|
tjprescott
reviewed
Aug 16, 2017
| @@ -81,7 +81,7 @@ def _get_feature_in_preview_message(): | |||
| # some admin names are prohibited in acs, such as root, admin, etc. Because we have no control on the orchestrators, so default to a safe name. | |||
| register_cli_argument('acs', 'admin_username', options_list=('--admin-username',), default='azureuser', required=False) | |||
| register_cli_argument('acs', 'api_version', options_list=('--api-version',), required=False, help=_get_feature_in_preview_message() + 'Use API version of ACS to perform az acs operations. Available options: 2017-01-31, 2017-07-01. Default to use the latest version for the location') | |||
| register_cli_argument('acs', 'dns_name_prefix', options_list=('--dns-prefix', '-d')) | |||
| register_cli_argument('acs', 'dns_name_prefix', options_list=('--dns-prefix', '-d'), help='default use the format of <clustername>-<resourcegroupname>-<subid>, will trim the length and replace sensitive charactors if needed') | |||
| if not name_part[0].isalpha(): | ||
| name_part = (str('a') + name_part)[0:10] | ||
| resource_group_part = re.sub('[^A-Za-z0-9-]', '', resource_group_name)[0:16] | ||
| dns_name_prefix = '{}-{}-{}'.format(name_part, resource_group_part, subscription_id[0:6]) |
There was a problem hiding this comment.
I'd recommend extracting this logic to method and adding a few unit tests.
rjtsdl
force-pushed
the
jiren-formatdnsprefix
branch
from
4457a4d
to
c57559e
Compare
|
@tjprescott , please help merge if you approve :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)