Allow user to specify an output format [114821361] #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Argument Parser returns an object containing the result and the output format specified Add tests for command output format specifying
| @@ -57,6 +58,10 @@ def _index(string, char, default=sys.maxsize): | |||
| except ValueError: | |||
| return default | |||
|
|
|||
| class ArgumentParserResult(object): #pylint: disable=too-few-public-methods | |||
There was a problem hiding this comment.
I believe that we'll have to end up with a generic session configuration/state mechanism rather than returning an argument parser result. There are more "global" parameters (i.e. verbosity level, subscription id etc.) that will have to be extracted before we hit individual command instance execution.
We can merge this in in it's current state as getting the output format cleaned up is high prio, but we should add an item to the backlog to make it more generic...
johanste
added a commit
that referenced
this pull request
Mar 7, 2016
Allow user to specify an output format [114821361]
tjprescott
pushed a commit
that referenced
this pull request
Jul 9, 2019
* NFSAAS-2316 update to R4 RP standard (#30) * NFSAAS-2316 update to R4 RP standard (#31) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS 2316 R4 update path correction (#32) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change (#33) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS 2316 R4 update remove wheel (#34) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * NFSAAS-2316 update to R4 remove wheel * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS-2316 R4 update packaging fixes (#35) * NFSAAS 2316 R4 update review comments (#36) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS 2316 R4 corrections to booleans (#37) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history (#38) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 R4 fixes (#39) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 Fixes (#40) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
Argument Parser returns an object containing the result and the output format specified
Add tests for command output format specifying