Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM] Fix issue with deployment parameter parsing #3743

Merged
merged 1 commit into from
Jun 15, 2017
Merged

[ARM] Fix issue with deployment parameter parsing #3743

merged 1 commit into from
Jun 15, 2017

Conversation

tjprescott
Copy link
Member

Fixes #3729.

Ensures that --parameters <JSON String> or --parameters @<file> no longer are ignored if the contents contain an = sign. Enhances existing test to protect against regressions for this scenario.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • [N/A] Each command and parameter has a meaningful description.
  • [N/A] Each new command has a test.

(see Authoring Command Modules)

@tjprescott tjprescott added bug This issue requires a change to an existing behavior in the product in order to be resolved. Resource Manager labels Jun 15, 2017
@tjprescott tjprescott added this to the Sprint 18 milestone Jun 15, 2017
@codecov-io
Copy link

codecov-io commented Jun 15, 2017

Codecov Report

Merging #3743 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3743   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files         421      421           
  Lines       26009    26009           
  Branches     3943     3943           
=======================================
  Hits        18765    18765           
  Misses       6025     6025           
  Partials     1219     1219
Impacted Files Coverage Δ
.../azure/cli/command_modules/resource/_validators.py 71.95% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e80e204...51d1a19. Read the comment docs.

@tjprescott tjprescott merged commit 757e40d into Azure:master Jun 15, 2017
@tjprescott tjprescott deleted the DeploymentParametersFixes branch June 15, 2017 23:59
@bencalegari
Copy link

Any idea when this will make it to a release?

@tjprescott
Copy link
Member Author

Typically when the current milestone ends (which is the first week of July). We may short-circuit this one due to an unrelated fix.

@mozehgir mozehgir added the ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group label Aug 14, 2019
@haroldrandom haroldrandom added bug This issue requires a change to an existing behavior in the product in order to be resolved. cla-not-required Resource Manager labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group bug This issue requires a change to an existing behavior in the product in order to be resolved. cla-not-required Resource Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants