Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pylint => 1.7.1 #3448

Merged
merged 1 commit into from
May 24, 2017
Merged

Upgrade pylint => 1.7.1 #3448

merged 1 commit into from
May 24, 2017

Conversation

troydai
Copy link
Contributor

@troydai troydai commented May 24, 2017

Update the pylint to version 1.7.1 and fixes the newly appeared issues. Notably:

:no-else-return (R1705): *Unnecessary "else" after "return"*
  else following a chain of ifs, all of them containing a return statement.

:len-as-condition (C1801): *Do not use `len(SEQUENCE)` as condition value*
  Used when Pylint detects incorrect use of len(sequence) inside conditions.
  implement __reversed__, nor __getitem__ and __len__

In addition, as a result of the upgrade, pylint is enabled in 3.6.

@troydai
Copy link
Contributor Author

troydai commented May 24, 2017

I would like to merge this change as soon as possible ti reduce the impacts from other pull requests since this impact a fairly large number of files.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoo... more pylint.

@@ -63,7 +63,7 @@ def list_adla_jobs(client,
job_list = client.list(account_name,
orderby="submitTime desc",
top=top if top <= 300 else None,
filter=filter_string if filter_string and len(filter_string) > 0 else None)
filter=filter_string if filter_string else None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe filter_string or None?

@troydai troydai merged commit 2e4010d into Azure:master May 24, 2017
@troydai troydai deleted the style branch May 24, 2017 23:44
@troydai
Copy link
Contributor Author

troydai commented May 24, 2017

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants