Repository navigation
[Network] az network application-gateway advanced-routing-map/advanced-routing-condition-set: Add new command groups to support advanced routing - #34198
Open
Jian Hui (huiii99) wants to merge 2 commits into
Conversation
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
Ethan Yang (necusjz) and
Yong Zhang (yonzhan)
October 9, 2026 02:33
microsoft-github-policy-service
Bot
added
Network
Collaborator
|
Network |
…ert_special_char_scenario recording
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new auth-config create/update and reserved-capacity update paths lack automated coverage.
1 open finding
What changed in this PR
Implements Application Gateway advanced routing for #34139 using API version 2026-01-01.
Changes:
- Adds condition-set, routing-map, and nested rule commands.
- Supports advanced routing maps and authentication configs on request-routing rules.
- Updates generated AAZ commands, scenario coverage, recordings, and linter exclusions.
| File | Description |
|---|---|
linter_exclusions.yml |
Adds exclusions for long routing-map options. |
network/commands.py |
Registers customized advanced-routing-map commands. |
network/custom.py |
Adds resource-ID formatting and first-rule orchestration. |
network/aaz/latest/network/application_gateway/** |
Upgrades generated commands to API 2026-01-01 and adds advanced-routing models. |
network/tests/latest/test_network_commands.py |
Adds the advanced-routing scenario. |
network/tests/latest/test_network_unit_tests.py |
Updates the expected API version. |
network/tests/latest/recordings/** |
Updates and adds Application Gateway recordings. |
monitor/tests/latest/recordings/test_metric_alert_special_char_scenario.yaml |
Updates the dependent Application Gateway API version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+230
to
+235
| _args_schema.reserved_capacity = AAZIntArg( | ||
| options=["--reserved-capacity"], | ||
| arg_group="Properties", | ||
| help="The reserved capacity of the application gateway resource. Applicable to the Basic_v2 and Basic_WAF_v2 SKU tiers.", | ||
| nullable=True, | ||
| ) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network application-gateway advanced-routing-condition-setaz network application-gateway advanced-routing-mapaz network application-gateway rule create/updateDescription
Resolves #34139. The generated code comes from Azure/aaz#1116.
az network application-gatewayto API version2026-01-01.advanced-routing-condition-set(with a nestedconditiongroup) andadvanced-routing-map(with a nestedrulegroup).advanced-routing-map createtakes the map's first rule inline, because the service requires every map to have at least one rule.rule create/update: adds--advanced-routing-map, used with--rule-type AdvancedRouting.Testing Guide
az network application-gateway advanced-routing-condition-set create -g MyResourceGroup --gateway-name MyAppGateway -n cs1 --routing-conditions "[{condition-type:Header,property-name:x-env,property-values:[canary]}]" az network application-gateway advanced-routing-map create -g MyResourceGroup --gateway-name MyAppGateway -n map1 --default-address-pool MyPool --default-http-settings MySettings --rule-name r1 --priority 10 --condition-set cs1 --address-pool MyPool --http-settings MySettings az network application-gateway rule create -g MyResourceGroup --gateway-name MyAppGateway -n rule2 --http-listener MyListener --rule-type AdvancedRouting --advanced-routing-map map1 --priority 200New scenario test:
test_network_ag_advanced_routing.History Notes
[Network]
az network application-gateway advanced-routing-condition-set/advanced-routing-map: Add new command groups to support advanced routing[Network]
az network application-gateway rule create/update: Add--advanced-routing-mapand--auth-configs[Network]
az network application-gateway update: Add--reserved-capacityThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.