-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry/enable app insights [Finished #114911063] #33
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
79b9830
Initial telemetry hookup (works on wire, not working server-side)
BurtBiel 84b57be
add user ID with no PII
BurtBiel 5314e8a
Add initial telemetry points
BurtBiel 0bcc955
remove custom interpreters
BurtBiel eed4ade
remove command line args
BurtBiel 2fe0bd8
added missing = sign
BurtBiel 42de26c
update perf timer usage
BurtBiel 69b9b97
merge master, undo perf timer changes
BurtBiel f7bcd30
update where telemetry calls are made
BurtBiel fb0549c
alphabetize requirements.txt
BurtBiel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
applicationinsights==0.10.0 | ||
azure==2.0.0rc1 | ||
mock==1.3.0 | ||
pylint==1.5.4 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import getpass | ||
from applicationinsights import TelemetryClient | ||
from applicationinsights.exceptions import enable | ||
import azure.cli as cli | ||
|
||
client = {} | ||
|
||
def init_telemetry(): | ||
try: | ||
instrumentation_key = 'eb6e9d3a-b6ee-41a6-804f-70e152fdfc36' | ||
|
||
global client #pylint: disable=global-statement | ||
client = TelemetryClient(instrumentation_key) | ||
|
||
client.context.application.id = 'Azure CLI' | ||
client.context.application.ver = cli.__version__ | ||
client.context.user.id = hash(getpass.getuser()) | ||
|
||
enable(instrumentation_key) | ||
except Exception: #pylint: disable=broad-except | ||
# Never fail the command because of telemetry | ||
pass | ||
|
||
def user_agrees_to_telemetry(): | ||
# TODO: agreement, needs to take Y/N from the command line | ||
# and needs a "skip" param to not show (for scripts) | ||
return True | ||
|
||
def telemetry_flush(): | ||
try: | ||
client.flush() | ||
except Exception: #pylint: disable=broad-except | ||
# Never fail the command because of telemetry | ||
pass |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do a pivotal bug for this so that we can discuss and decide where this information should be persisted for the session. Perhaps a config.json like we have for Node CLI.