{Compute} az vm resize: Migrate commands to aaz
#32618
Open
+2,220
−637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiii99
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the az vm resize command from the legacy mgmt.compute SDK to the AAZ (Azure API Auto-generation) framework, modernizing the implementation while maintaining backward compatibility with the existing behavior.
Key changes:
- Refactored
resize_vmfunction to use AAZ-based VMUpdate and VMShow operations - Added logic to detect and skip redundant resize operations when VM is already the target size
- Included a new integration test that validates the resize functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Migrated resize_vm function from mgmt.compute to AAZ framework, implementing pre_instance_update and post_operations hooks |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Added VMResizeScenarioTest with test_vm_resize_changes_size to validate resize functionality |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_resize_changes_size.yaml | Generated test recording for the resize test scenario |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yanzhudd
changed the title
az vm resize: Migrate commands to aaz
huiii99
force-pushed
the
vm-restart-resize-migration
branch
from
cfcab69 to
da211a5
Compare
dev dev fix: re run test recording dev dev
huiii99
force-pushed
the
vm-restart-resize-migration
branch
from
da211a5 to
c691c86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm resizeDescription
Migration from mgmt.compute to aaz-based
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.