-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm extension: support 'set' and 'list' #326
Conversation
@@ -62,3 +62,6 @@ src/build | |||
|
|||
# Auxiliary files | |||
command_coverage.txt | |||
|
|||
#Test artifacts | |||
private_config.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extension_set tests will create this file and feed it to the command. Though tests will delete it after done, but I still exclude it just in case people use ctrl+c to stop the test run.
/CC: @johanste, @BurtBiel, @derekbekoe |
if os.path.exists(string_or_file): | ||
with open(string_or_file, 'r') as f: | ||
content = f.read() | ||
return content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a copy of this in _actions. If we could factor them, that would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will do it.
No description provided.