[AKS] az aks nodepool update: Add GPU driver install options install and none for --gpu-driver parameter
#32531
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilypan26
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add support for the --gpu-driver parameter to the az aks nodepool update command to address issue #32516, allowing users to set GPU driver installation mode (including "none") when updating nodepools. However, the implementation is incomplete.
Key Changes
- Adds
gpu_driverparameter registration to theaks nodepool updatecommand argument context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| c.argument("if_match") | ||
| c.argument("if_none_match") | ||
| c.argument('localdns_config', help='Path to a JSON file to configure the local DNS profile for a new nodepool.') | ||
| c.argument('gpu_driver', arg_type=get_enum_type(gpu_driver_install_modes)) |
There was a problem hiding this comment.
Adding the gpu_driver parameter here is incomplete. This change requires three additional modifications to work correctly:
- The
aks_agentpool_updatefunction signature incustom.py(around line 2947) needs to include agpu_driver=Noneparameter - The
AKSAgentPoolUpdateDecoratorclass needs anupdate_gpu_profilemethod similar to theset_up_gpu_profilemethod inAKSAgentPoolAddDecorator(see line 2172 in agentpool_decorator.py) - The
update_agentpool_profile_defaultmethod inAKSAgentPoolUpdateDecorator(around line 2625) needs to call the newupdate_gpu_profilemethod
Without these changes, the parameter will be accepted by the CLI but won't actually update the GPU driver configuration on the nodepool.
lilypan26
changed the title
az aks nodepool update: Add GPU driver install options install and none for --gpu-driver parameter
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Dec 12, 2025
| c.argument("if_match") | ||
| c.argument("if_none_match") | ||
| c.argument('localdns_config', help='Path to a JSON file to configure the local DNS profile for a new nodepool.') | ||
| c.argument('gpu_driver', arg_type=get_enum_type(gpu_driver_install_modes)) |
Member
There was a problem hiding this comment.
I believe you also need to declare this parameter in the entry function corresponding to the command, which is aks_agentpool_update in custom.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks nodepool update --gpu-driver noneDescription
Addresses github issue: #32516. Users with SkipGPUDriverInstall nodepool tag should be allowed to set
--gpu-driver Noneupon nodepool update.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.