Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Update data plane SDK to 0.3.0 #3251

Merged
merged 7 commits into from
May 10, 2017

Conversation

schaabs
Copy link
Member

@schaabs schaabs commented May 8, 2017


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@msftclas
Copy link

msftclas commented May 8, 2017

@schaabs,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@schaabs
Copy link
Member Author

schaabs commented May 8, 2017

@tjprescott This change is to update the cli command modules to use the recent azure-keyvault sdk changes, from this pull request: Azure/azure-sdk-for-python#1137

This change shouldn't be merged until the corresponding sdk changes are merged and packages available.

There is no added commands or functionality just some updates to consume a backwards breaking change in the azure-keyvault sdk. The only affected command modules are azure-cli-keyvault and azure-cli-vm. I don't have access to add reviewers so please add as relevant.

@tjprescott tjprescott changed the title Sdk refactor updates [KeyVault] Update data plane SDK to 0.3.0 May 8, 2017
@tjprescott tjprescott added the KeyVault az keyvault label May 8, 2017
@tjprescott tjprescott self-requested a review May 8, 2017 21:52
@codecov-io
Copy link

codecov-io commented May 9, 2017

Codecov Report

Merging #3251 into master will decrease coverage by <.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   70.27%   70.27%   -0.01%     
==========================================
  Files         391      391              
  Lines       25084    25080       -4     
  Branches     3813     3812       -1     
==========================================
- Hits        17629    17625       -4     
  Misses       6348     6348              
  Partials     1107     1107
Impacted Files Coverage Δ
...vm/azure/cli/command_modules/vm/disk_encryption.py 52.31% <0%> (ø) ⬆️
...vault/azure/cli/command_modules/keyvault/custom.py 67.37% <100%> (ø) ⬆️
...zure-cli-vm/azure/cli/command_modules/vm/custom.py 73.13% <100%> (ø) ⬆️
...zure/cli/command_modules/keyvault/_command_type.py 77.46% <100%> (-0.92%) ⬇️
.../azure/cli/command_modules/keyvault/_validators.py 72.84% <100%> (ø) ⬆️
...ault/azure/cli/command_modules/keyvault/_params.py 86.15% <100%> (ø) ⬆️
...ult/azure/cli/command_modules/keyvault/commands.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc9977...2e01297. Read the comment docs.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this doesn't having any customer facing effects, please remove the release notes and since Laurent has bumped the SDK to fix the SSL bug, please bump that here. Otherwise LGTM!

2.0.3 (2017-05-05)
++++++++++++++++++++

* Minor fixes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is for customer facing changes only. Since the command surface area hasn't changed, nothing is required (or desired) here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -35,7 +35,7 @@

DEPENDENCIES = [
'azure-mgmt-keyvault==0.31.0',
'azure-keyvault==0.2.0',
'azure-keyvault==0.3.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Laurent has bumped the version to fix the SSL issue on proxies, could you bump this to 0.3.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped to 0.3.1

++++++++++++++++++

* updating VM command module to use azure-keyvault SDK 0.3.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry is also not needed.

@@ -34,7 +34,7 @@
DEPENDENCIES = [
'azure-mgmt-compute==1.0.0rc1',
'azure-mgmt-keyvault==0.31.0',
'azure-keyvault==0.2.0',
'azure-keyvault==0.3.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please bump here too.

@tjprescott tjprescott changed the title [KeyVault] Update data plane SDK to 0.3.0 [KeyVault] Update data plane SDK to 0.3.1 May 9, 2017
@schaabs
Copy link
Member Author

schaabs commented May 9, 2017

@tjprescott azure-keyvault 0.3.1 introduces a bug in keyvault authentication. Moving to 0.3.0 until the issue is fixed.

@schaabs schaabs changed the title [KeyVault] Update data plane SDK to 0.3.1 [KeyVault] Update data plane SDK to 0.3.0 May 9, 2017
@tjprescott tjprescott merged commit 7912b61 into Azure:master May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants