-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KeyVault] Update data plane SDK to 0.3.0 #3251
Conversation
- updating namespace imports - updating release history
@schaabs, |
@tjprescott This change is to update the cli command modules to use the recent azure-keyvault sdk changes, from this pull request: Azure/azure-sdk-for-python#1137 This change shouldn't be merged until the corresponding sdk changes are merged and packages available. There is no added commands or functionality just some updates to consume a backwards breaking change in the azure-keyvault sdk. The only affected command modules are azure-cli-keyvault and azure-cli-vm. I don't have access to add reviewers so please add as relevant. |
Codecov Report
@@ Coverage Diff @@
## master #3251 +/- ##
==========================================
- Coverage 70.27% 70.27% -0.01%
==========================================
Files 391 391
Lines 25084 25080 -4
Branches 3813 3812 -1
==========================================
- Hits 17629 17625 -4
Misses 6348 6348
Partials 1107 1107
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this doesn't having any customer facing effects, please remove the release notes and since Laurent has bumped the SDK to fix the SSL bug, please bump that here. Otherwise LGTM!
2.0.3 (2017-05-05) | ||
++++++++++++++++++++ | ||
|
||
* Minor fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is for customer facing changes only. Since the command surface area hasn't changed, nothing is required (or desired) here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@@ -35,7 +35,7 @@ | |||
|
|||
DEPENDENCIES = [ | |||
'azure-mgmt-keyvault==0.31.0', | |||
'azure-keyvault==0.2.0', | |||
'azure-keyvault==0.3.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Laurent has bumped the version to fix the SSL issue on proxies, could you bump this to 0.3.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumped to 0.3.1
++++++++++++++++++ | ||
|
||
* updating VM command module to use azure-keyvault SDK 0.3.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry is also not needed.
@@ -34,7 +34,7 @@ | |||
DEPENDENCIES = [ | |||
'azure-mgmt-compute==1.0.0rc1', | |||
'azure-mgmt-keyvault==0.31.0', | |||
'azure-keyvault==0.2.0', | |||
'azure-keyvault==0.3.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please bump here too.
…in keyvault authentication
@tjprescott azure-keyvault 0.3.1 introduces a bug in keyvault authentication. Moving to 0.3.0 until the issue is fixed. |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)