-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ACR] az acr config content-trust update, az acr check-health: Add breaking changes announcement
#32462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[ACR] az acr config content-trust update, az acr check-health: Add breaking changes announcement
#32462
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds breaking change announcements for two Azure Container Registry (ACR) commands in preparation for the deprecation of Docker Content Trust on March 31, 2028.
- Imports
register_logic_breaking_changefunction from the core breaking change module - Registers breaking change for
az acr check-healthto notify users that Notary client version validation will be removed - Registers breaking change for
az acr config content-trust updateto notify users that the--status enabledparameter will no longer be accepted
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yizha1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizMSFT LGTM, I didn't see this sentence shown in your screenshot. Would it be better to say: "To learn more about deprecation" instead of "breaking change"?
Related command
az acr config content-trust updateaz acr check-healthDescription
Azure Container Registry will retire Docker Content Trust on March 31, 2028. For more details, refer to https://aka.ms/acr/dctdeprecation.
az acr config content-trust updatestating that theenabledstatus value will no longer be accepted in the next breaking change release.az acr check-healthstating that the Notary client check will be removed in the next breaking change release.Testing Guide


History Notes
[ACR]
az acr config content-trust update: add breaking changes announcement thatenabledstatus will no longer be accepted[ACR]
az acr check-health: add breaking change announcement that Notary client check will be removedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.