-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress Reporting for long running operations #3243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this PR only has changes for progress reporting. I see frequency.json
in these changes.
@@ -63,6 +64,7 @@ def __init__(self): | |||
self.config.add_section('Layout') | |||
self.config.set('Help Files', 'command', 'help_dump.json') | |||
self.config.set('Help Files', 'history', 'history.txt') | |||
self.config.set('Help Files', 'frequency', 'frequency.json') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I removed it
message = args.get('message', '') | ||
|
||
if percent: | ||
percent = percent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line does nothing right? Should remove if true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right; I just removed it
|
||
def update(self): | ||
""" updates the view with the progress """ | ||
# TODO APPROPRIATE PROGRESS SENT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove todo?
@@ -0,0 +1,23 @@ | |||
interactions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this added accidently?
Can you remove.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)