Progress Reporting for long running operations #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 24, 2017 13:22
derekbekoe
reviewed
May 16, 2017
| @@ -63,6 +64,7 @@ def __init__(self): | |||
| self.config.add_section('Layout') | |||
| self.config.set('Help Files', 'command', 'help_dump.json') | |||
| self.config.set('Help Files', 'history', 'history.txt') | |||
| self.config.set('Help Files', 'frequency', 'frequency.json') | |||
There was a problem hiding this comment.
This shouldn't be here right?
derekbekoe
reviewed
May 18, 2017
| message = args.get('message', '') | ||
|
|
||
| if percent: | ||
| percent = percent |
There was a problem hiding this comment.
This line does nothing right? Should remove if true.
There was a problem hiding this comment.
You're right; I just removed it
added 15 commits
May 18, 2017 10:52
derekbekoe
reviewed
May 22, 2017
|
|
||
| def update(self): | ||
| """ updates the view with the progress """ | ||
| # TODO APPROPRIATE PROGRESS SENT |
| @@ -0,0 +1,23 @@ | |||
| interactions: | |||
There was a problem hiding this comment.
Was this added accidently?
Can you remove.
derekbekoe
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)