Progress Reporting for Long Running Operations + Custom Commands #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 24, 2017 13:22
added 17 commits
May 4, 2017 15:10
|
@troydai and @derekbekoe, can you please take another look |
|
Reviewing. |
derekbekoe
reviewed
May 5, 2017
|
|
||
| def stop(self): | ||
| """ if there is an abupt stop before ending """ | ||
| self.add(message='Interupted') |
| shell.cli.buffers['progress'].reset( | ||
| initial_document=Document(doc)) | ||
| shell.cli.request_redraw() | ||
| if PROGRESS == 'Finished' or PROGRESS == 'Interupted': |
troydai
approved these changes
May 5, 2017
derekbekoe
approved these changes
May 5, 2017
derekbekoe
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)