-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress Reporting for Long Running Operations + Custom Commands #3130
Conversation
@troydai and @derekbekoe, can you please take another look |
Reviewing. |
|
||
def stop(self): | ||
""" if there is an abupt stop before ending """ | ||
self.add(message='Interupted') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo with 'Interupted'
shell.cli.buffers['progress'].reset( | ||
initial_document=Document(doc)) | ||
shell.cli.request_redraw() | ||
if PROGRESS == 'Finished' or PROGRESS == 'Interupted': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo 'Interupted'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)