Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: capture exceptions caused by unregistered provider and auto-register it #3045

Merged
merged 10 commits into from
May 1, 2017
Merged

core: capture exceptions caused by unregistered provider and auto-register it #3045

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b67e2da
use error code to polish rp not registered error
yugangw-msft Apr 22, 2017
8f4b354
fix style check error
yugangw-msft Apr 24, 2017
8f307b1
wip
yugangw-msft Apr 24, 2017
ce7439b
update project file
yugangw-msft Apr 27, 2017
367727a
update test
yugangw-msft Apr 27, 2017
6e50795
update tests
yugangw-msft Apr 27, 2017
6dd1b01
fix py 2.7 specific error
yugangw-msft Apr 27, 2017
30c22ac
update history
yugangw-msft Apr 27, 2017
a5ea769
remove a pylint suppression
yugangw-msft Apr 28, 2017
5c857c9
address review feedback
yugangw-msft May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove a pylint suppression
  • Loading branch information
@yugangw-msft
yugangw-msft committed May 1, 2017
commit a5ea769416ed648f8c4bc0f38f1039a23ce97a6b
10 changes: 5 additions & 5 deletions src/azure-cli-core/tests/test_rp_auto_reg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,22 @@
from azure.cli.core.commands import _check_rp_not_registered_err


# pylint: disable=line-too-long


class TestRPAutoRegister(ScenarioTest):
def setUp(self):
if self.in_recording:
# note, unregistering a registered provider might take a long while(10+ mins)
result = self.cmd('provider show -n Microsoft.Sql --query "registrationState" -o tsv').output
result = self.cmd('provider show -n Microsoft.Sql '
'--query "registrationState" -o tsv').output
if result.lower().strip() != 'unregistered':
self.cmd('provider unregister -n Microsoft.Sql --wait')
time.sleep(30) # a bit random but like to ensure unregistering went through
return super(TestRPAutoRegister, self).setUp()

@ResourceGroupPreparer()
def test_rp_auto_register(self, resource_group, resource_group_location):
self.cmd('sql server create -g {} -n ygserver123 -l {} --admin-user sa123 --admin-password verySecret12345'.format(resource_group, resource_group_location), checks=[
cmd = ('sql server create -g {} -n ygserver123 -l {} --admin-user sa123 '
'--admin-password verySecret12345')
self.cmd(cmd.format(resource_group, resource_group_location), checks=[
JMESPathCheck('name', 'ygserver123')
])
self.cmd('provider show -n Microsoft.Sql', checks=[
Expand Down