-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Core} Migrate generate_ssh_keys
from paramiko
to cryptography
#30063
base: dev
Are you sure you want to change the base?
Conversation
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Core |
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py Line 466 in aec2b88
|
paramiko
dependency from coregenerate_ssh_keys
from paramiko
to cryptography
|
||
|
||
def _open(filename, mode): | ||
return os.open(filename, flags=os.O_WRONLY | os.O_TRUNC | os.O_CREAT, mode=mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting file mode at creation time avoids the time gap between open
and chmod
. See #21719
Description
Migrate
generate_ssh_keys
fromparamiko
tocryptography
.https://cryptography.io/en/latest/hazmat/primitives/asymmetric/rsa/ contains some useful examples for working with RSA keys.