[AKS] az aks create/update: Add --network-policy none option to command
#29420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robogatikov
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update update parameter network_policy: added property choices=['azure', 'calico', 'cilium', 'none'] |
|
AKS |
microsoft-github-policy-service
bot
requested review from
yonzhan,
kairu-ms,
AllyW,
necusjz and
FumingZhang
microsoft-github-policy-service
bot
added
the
Network
robogatikov
force-pushed
the
robogatikov/netpol-none
branch
from
d17e60f
to
04e3e48
Compare
wedaly
suggested changes
Jul 19, 2024
robogatikov
force-pushed
the
robogatikov/netpol-none
branch
2 times, most recently
from
514366b
to
c72c1f6
Compare
wedaly
approved these changes
Jul 19, 2024
|
Please fix CI issues |
FumingZhang
reviewed
Jul 22, 2024
There was a problem hiding this comment.
lgtm, please rerun CI checks (e.g., push an empty commit).
Queued live test.
- test_aks_uninstall_azure_npm
- test_aks_install_azure_npm
- test_aks_uninstall_calico_npm
- test_aks_install_calico_npm
robogatikov
force-pushed
the
robogatikov/netpol-none
branch
from
c72c1f6
to
b037b6f
Compare
robogatikov
changed the title
FumingZhang
reviewed
Jul 22, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
robogatikov
changed the title
robogatikov
changed the title
--network-policy=none to az aks create/update command
robogatikov
force-pushed
the
robogatikov/netpol-none
branch
from
3c630ef
to
6312f8e
Compare
The live test failed due to the feature requires API version to be >= 2024-05-01. Need to wait until #29436 is merged. |
#29436 is merged. Please rebase from main to pick up the change and update the recording file in your PR accordingly. @robogatikov |
robogatikov
force-pushed
the
robogatikov/netpol-none
branch
from
6312f8e
to
3d97b84
Compare
wedaly
approved these changes
Jul 25, 2024
|
Seems the recording files you uploaded were generated with aks-preview installed : )
You could use the recording files from this pipeline artifact |
robogatikov
force-pushed
the
robogatikov/netpol-none
branch
from
a19a7ff
to
08b4daf
Compare
yanzhudd
changed the title
--network-policy=none to az aks create/update commandaz aks create/update: Add --network-policy none option to command
yanzhudd
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create/update
Description
We are adding --network-policy=none option. "none" is currently the default value when network policy is not specified. This change is needed to support Uninstall Network Policy Engine feature (Azure Network Policy Manager or Calico)
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.