{Batch} Fix race condition in test #28508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Batch |
zhoxing-ms
previously approved these changes
Mar 7, 2024
|
@bebound Could you please help review this PR? |
jiasli
reviewed
Mar 8, 2024
src/azure-cli/azure/cli/command_modules/batch/tests/latest/test_batch_mgmt_commands.py
Outdated
Show resolved
Hide resolved
|
This issue should be addressed as soon as possible as it is causing more CI failures: https://dev.azure.com/azclitools/public/_build?definitionId=32&_a=summary&branchFilter=487%2C487%2C487%2C487 |
bebound
changed the title
zhoxing-ms
approved these changes
Mar 15, 2024
bebound
approved these changes
Mar 15, 2024
jiasli
approved these changes
Mar 15, 2024
jiasli
requested changes
Mar 15, 2024
Comment on lines
+347
to
+348
| def __init__(self, method_name, *arg, **kwargs): | ||
| super().__init__(method_name, *arg, random_config_dir=True, **kwargs) |
There was a problem hiding this comment.
No need to explicitly specify method_name. It is part of *arg.
Suggested change
| def __init__(self, method_name, *arg, **kwargs): | |
| super().__init__(method_name, *arg, random_config_dir=True, **kwargs) | |
| def __init__(self, *arg, **kwargs): | |
| super().__init__(*arg, random_config_dir=True, **kwargs) |
There was a problem hiding this comment.
Well, as this pattern is frequently used elsewhere:
You can keep it for now.
jiasli
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #28500
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.