[Containerapp] az containerapp: Change the container-app name and container-app job name in the example to legal names
#27933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yanzhudd and
zhoxing-ms
|
containerapp |
microsoft-github-policy-service
bot
requested review from
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl and
jijohn14
Juliehzl
approved these changes
Nov 28, 2023
|
Hi @zhoxing-ms Could you help to review and merge this PR? Thanks! |
|
Please add some comments in the PR description to explain why do you need to modify the sample value. |
zhoxing-ms
changed the title
zhoxing-ms
changed the title
az containerapp: Change the container-app name and container-app job name in the example to legal names
zhoxing-ms
approved these changes
Nov 28, 2023
zhoxing-ms
changed the title
az containerapp: Change the container-app name and container-app job name in the example to legal namesaz containerapp: Change the container-app name and container-app job name in the example to legal names
albertofori
pushed a commit
to albertofori/azure-cli
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
When using the containerapp name
MyContainerappin the example of help directly, it will throw following error:(ContainerAppInvalidName) Invalid ContainerApp name 'MyContainerapp'. A name must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character and cannot have '--'. The length must not be more than 32 characters.
So, we need to update the name in example to legal names.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.