{CI} Remove --exitfirst to collect all error information at once.
#27291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzelin007
requested review from
kairu-ms,
jiasli,
calvinhzy and
bebound
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
CI |
jiasli
reviewed
Aug 31, 2023
| @@ -17,7 +17,7 @@ | |||
| root_dir = '{}/lib/{}/site-packages/azure/cli/command_modules'.format(az_base, python_version) | |||
| mod_list = [mod for mod in sorted(os.listdir(root_dir)) if os.path.isdir(os.path.join(root_dir, mod)) and mod != '__pycache__'] | |||
|
|
|||
| pytest_base_cmd = 'PYTHONPATH={}/lib/{}/site-packages python -m pytest -x -v --forked -p no:warnings --log-level=WARN'.format(az_base, python_version) | |||
There was a problem hiding this comment.
This line was introduced by #14372.
jiasli
reviewed
Aug 31, 2023
| @@ -10,7 +10,7 @@ | |||
| root_dir = '/opt/az/lib/python3.10/site-packages/azure/cli/command_modules' | |||
| mod_list = [mod for mod in sorted(os.listdir(root_dir)) if os.path.isdir(os.path.join(root_dir, mod)) and mod != '__pycache__'] | |||
|
|
|||
| pytest_base_cmd = '/opt/az/bin/python3 -m pytest -x -v --forked -p no:warnings --log-level=WARN' | |||
There was a problem hiding this comment.
This line was introduced by #14843.
jiasli
reviewed
Aug 31, 2023
| @@ -11,7 +11,7 @@ | |||
| root_dir = f'/usr/lib64/az/lib/{python_version}/site-packages/azure/cli/command_modules' | |||
| mod_list = [mod for mod in sorted(os.listdir(root_dir)) if os.path.isdir(os.path.join(root_dir, mod)) and mod != '__pycache__'] | |||
|
|
|||
| pytest_base_cmd = f'PYTHONPATH=/usr/lib64/az/lib/{python_version}/site-packages python -m pytest -x -v --forked -p no:warnings --log-level=WARN' | |||
There was a problem hiding this comment.
This line was introduced by #14288.
|
I personally don't like this " |
jiasli
approved these changes
Aug 31, 2023
bebound
approved these changes
Aug 31, 2023
Totally agree, most of the time I will manually add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
-x, --exitfirstmeans exit instantly on first error or failed test.Remove
--exitfirstto collect all error information at once so we can fix test issues in one go.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.