{Core} Directly call acquire_token_for_client to acquire access token for service principal
#27002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
evelyn-ys,
calvinhzy,
jsntcy,
kairu-ms,
zhoxing-ms and
necusjz
as code owners
🔄AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
|
Core |
jiasli
commented
Jul 26, 2023
| result = self.acquire_token_silent(scopes, None, **kwargs) | ||
| if not result: | ||
| result = self.acquire_token_for_client(scopes, **kwargs) | ||
| result = self.acquire_token_for_client(scopes, **kwargs) |
There was a problem hiding this comment.
This change is purely for code cleanliness.
MSAL 1.24.0b1 installed by #26980 will also include this functionality, as calling acquire_token_silent with account=None is now a no-op:
if not account:
return None # A backward-compatible NO-OP to drop the account=None usage
evelyn-ys
previously approved these changes
Jul 26, 2023
MoChilia
previously approved these changes
Jul 26, 2023
evelyn-ys
approved these changes
Jul 27, 2023
yonzhan
modified the milestones:
September 2023 (2023-09-26),
October 2023 (2023-11-15)❗ Breaking change release ❗
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bebound
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
MSAL 1.23.0 (AzureAD/microsoft-authentication-library-for-python#581) changed the behavior of
acquire_token_for_clientso that it will automatically look up access tokens from cache, so there is no need to callacquire_token_silentand check the result manually then callacquire_token_for_client.The MSAL example also reflects the same:
https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/95df6086ec186e395186e097f8c9103c4ee74d83/sample/confidential_client_secret_sample.py#L53-L55