-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{ARM} Bump api-version for Microsoft.Resources from 2021-04-01 to 2022-09-01 #25434
Changes from all commits
c3bddb1
fa0298f
ccdb671
55f9f41
5214a50
5aca3e5
3679f8e
c06f36c
5b340f5
1034a7f
8534654
9156c4b
48d066b
f1852e2
6f97566
f088b7d
b112a29
4a0ce60
33230a0
3d031c9
e5d3ee5
a24e411
1348a2e
b4e2184
7b93a02
cd913bc
11ab499
0542e7d
a1825c0
4494f7e
b09f26f
cd47d05
f9b841a
1082800
015c233
44c6d72
dc15555
1e5a6a7
c02bf89
2f51bc5
471ed8f
b67b2dc
1ef0a62
0d4f4c6
aab1fa3
461eb32
1500739
348197a
a305bac
559d6e2
6dd3b66
49f9b65
6d87d35
93a8a0b
f9d4127
cf40845
33a744b
c7a4302
80459bd
f03c7cb
8816cad
a8358e4
26df2e1
d5b3a21
5432601
68dc481
f66c4d4
0dda07c
8dfb51d
3e84f9d
b84a904
e1c56c6
7afd605
e24aed0
6296b10
bbe59c9
81002f0
ead308c
d12b5fe
c2c1812
e1da1a3
859a6fb
cd518fa
aab0f86
c76627e
b00e094
a1672f7
8d8a03f
8d4c0ad
0fc6c54
c782e20
9afae27
e4836aa
54fc21f
1558f8e
c7f1f87
bdebc83
5c2c1c5
2b32937
eb1a3c9
c552e8e
a7f0302
89c8fcd
a6c0aac
8290005
bed4538
73a5f15
fcf85a4
96b45b3
3fb5186
eedb87f
23ebda7
e9c0555
6ab10f5
4df0841
2005876
72073b6
cec6e9e
6c964a2
43e8b59
0732b07
7314615
5cc55ae
356d417
394e586
0674fa6
ed68c73
864e9ae
1ce94c1
2efed63
ba5fe38
cfda9a4
daa9f4f
18cfa48
e31b969
1a4fd38
2c958a7
684fcdc
528d3e4
039ec0b
88ac523
2bae6a9
7df8040
2390302
c57b5c1
4900cdb
979984c
018858b
84b2119
a435418
d8f9715
a2bb603
fce9100
dfafbf1
635eb24
2425153
fd6d1e8
44ffe5a
da5358c
451375e
fed1d0f
dff4f85
ed62d5e
84f0591
5ebc9fd
73b2289
cf99a3f
4898bd5
c8e3cd7
d5c086f
98ed672
d9614cf
6e04fed
78a8f07
83fe80d
81e1b8a
b7a8241
d7e93e4
1615b69
472eac1
97072a6
7226abd
eda6d36
b3c8b94
606e675
659dc8f
36124a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new resource type seems not being used, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! Thanks for your reminding!
In the past,
azure.mgmt.resource.managedapplications
was a single version directory, the client path in_resource_managedapps_client_factory
was directly imported by hardcode without usingResourceType
.azure-cli/src/azure-cli/azure/cli/command_modules/resource/_client_factory.py
Lines 49 to 52 in 946e67e
In all
managedapplications
related custom methods,_resource_managedapps_client_factory()
is directly called without using theclient
defined by command registration, such as:azure-cli/src/azure-cli/azure/cli/command_modules/resource/custom.py
Lines 1417 to 1432 in 946e67e
Due to a breaking change in the SDK
azure.mgmt.resource.managedapplications
, an additional directory version folderv2018_06_01
has been added to the original directory, resulting in theModuleNotFoundError: No module named 'azure.mgmt.resource.managedapplications.operations'
issue. issue link: #25828Therefore, we have added the new ResourceType
MGMT_RESOURCE_MANAGEDAPPLICATIONS
to solve theModuleNotFoundError
, because this way specifies the version path of theazure.mgmt.resource.managedapplications.operations
azure-cli/src/azure-cli-core/azure/cli/core/commands/command_operation.py
Lines 51 to 59 in 946e67e
More context: #24211 (comment)
Currently, there is indeed no direct use of the new resource type, which is not a good implementation way and can be confusing. I will refine the legacy code here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refined the legacy code, please help review again~