{SQL} az sql midb log-replay stop: Adjust error handling for new API version
#24121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from
ostojicb
commented
Oct 6, 2022
| @@ -2131,6 +2131,10 @@ def _configure_security_policy_storage_params(arg_ctx): | |||
| ############################################### | |||
| # sql managed db # | |||
| ############################################### | |||
| class ContainerIdentityType(Enum): | |||
There was a problem hiding this comment.
branched out of here #24105 to avoid conflicts, since we're both working with new sql sdk, similar commands
ostojicb
changed the title
az sql midb log-replay stop: adjust error handling for new API versionaz sql midb log-replay stop: Adjust error handling for new API version
|
SQL |
ostojicb
commented
Oct 7, 2022
Comment on lines
5212
to
5237
| try: | ||
| # Determine if managed DB was created using log replay service | ||
| # Raises RestoreDetailsNotAvailableOrExpired exception if there are no restore details | ||
| restore_details = restore_details_client.get( | ||
| database_name=database_name, | ||
| managed_instance_name=managed_instance_name, | ||
| resource_group_name=resource_group_name, | ||
| restore_details_name=RestoreDetailsName.DEFAULT) | ||
|
|
||
| # Determine if managed DB was created using log replay service, raise exception if not | ||
| restore_details = restore_details_client.get( | ||
| database_name=database_name, | ||
| managed_instance_name=managed_instance_name, | ||
| resource_group_name=resource_group_name, | ||
| restore_details_name=RestoreDetailsName.DEFAULT) | ||
|
|
||
| # If type is present, it must be lrsrestore in order to proceed with stop-log-replay | ||
| if (hasattr(restore_details, 'type_properties_type') and restore_details.type_properties_type.lower() != 'lrsrestore'): | ||
| raise CLIError( | ||
| f'Cannot stop the log replay as database {database_name} on the instance {managed_instance_name} ' | ||
| f'in the resource group {resource_group_name} was not created with log replay service.') | ||
|
|
||
| return client.begin_delete( | ||
| database_name=database_name, | ||
| managed_instance_name=managed_instance_name, | ||
| resource_group_name=resource_group_name) | ||
| # Type must be LRSRestore in order to proceed with stop-log-replay | ||
| if (restore_details.type_properties_type.lower() == 'lrsrestore'): | ||
| return client.begin_delete( | ||
| database_name=database_name, | ||
| managed_instance_name=managed_instance_name, | ||
| resource_group_name=resource_group_name) | ||
| else: | ||
| raise CLIError( | ||
| f'Cannot stop the log replay as database {database_name} on the instance {managed_instance_name} ' | ||
| f'in the resource group {resource_group_name} was not created with log replay service.') | ||
| except Exception as ex: | ||
| # | ||
| if (ex and 'RestoreDetailsNotAvailableOrExpired' in str(ex)): | ||
| raise CLIError( | ||
| f'Cannot stop the log replay as database {database_name} on the instance {managed_instance_name} ' | ||
| f'in the resource group {resource_group_name} was not created with log replay service.') | ||
| raise ex |
There was a problem hiding this comment.
this is the actual diff (once we merge #24105)
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
can we proceed with merging @wangzelin007 @evelyn-ys |
evelyn-ys
approved these changes
Oct 24, 2022
evelyn-ys
changed the title
az sql midb log-replay stop: Adjust error handling for new API versionaz sql midb log-replay stop: Adjust error handling for new API version
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…I version (Azure#24121) * bump version * add new parameter * record failing tests * more tests rec * simplify checks and adjust err handling for new version of midb restore details API * more fixing * put corrrect mask * one more * zone tests recorded on eastus * fix style errs * fix style issues Co-authored-by: Milan Brkic <mibrkic@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sql log-replay stopaz sql log-replay showDescription
We've got new version of managed database restore details API which we use to determine whether
log-replay stopcmd should drop the db or not (#22939).As the API now returns an error for dbs with no restore details, we'd ideally want to map it to a more meaningful exception in the context of this command.
Also new properties in API response can be used to simplify checking logic.
az sql log-replay showis a simple pass-through command, so new fields from API response are automatically passed back to the userTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.