Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate AI SDK's problem with numeric in properties #2397

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Mitigate AI SDK's problem with numeric in properties #2397

merged 1 commit into from
Mar 8, 2017

Conversation

troydai
Copy link
Contributor

@troydai troydai commented Mar 6, 2017

This is requested by VS business insights. The application insight SDK will convert numeric value in the properties values to string type. To allow these values types unchanged, numeric values should be saved through measurements argument on track_event method. It is a odd design, but it is what it is.

@troydai troydai requested a review from derekbekoe March 7, 2017 06:14
@codecov-io
Copy link

Codecov Report

Merging #2397 into master will decrease coverage by -0.04%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   72.33%   72.29%   -0.04%     
==========================================
  Files         323      323              
  Lines       18273    18284      +11     
  Branches     2701     2704       +3     
==========================================
+ Hits        13217    13218       +1     
- Misses       4223     4233      +10     
  Partials      833      833
Impacted Files Coverage Δ
.../azure-cli-core/azure/cli/core/telemetry_upload.py 21.95% <7.69%> (-4.72%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0fdcf...15dd2b0. Read the comment docs.

@troydai
Copy link
Contributor Author

troydai commented Mar 8, 2017

@derekbekoe?

@troydai troydai requested a review from tjprescott March 8, 2017 05:28
@troydai troydai merged commit a897493 into Azure:master Mar 8, 2017
@troydai troydai deleted the telemetry branch March 8, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants