[AKS] az aks create: Add --network-plugin=none support for BYO CNI
#23339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstam
requested review from
zhoxing-ms,
andyliuliming and
jsntcy
as code owners
ghost
requested review from
ghost
added
the
|
AKS |
FumingZhang
reviewed
Jul 27, 2022
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') | ||
| def test_aks_create_with_network_plugin_none(self, resource_group, resource_group_location): |
There was a problem hiding this comment.
Queued a pipeline to run the test in live mode. Passed.
Please upload the recording file from the artifact of the above pipeline.
|
@mattstam Could you please upload the recording file for |
|
@mattstam Please note that if you do not resolve the CI issue before Thursday, this PR will not be able to catch up with the release of this sprint, we can only postpone it to the next sprint (09-06) |
3 tasks
FumingZhang
reviewed
Jul 27, 2022
| @@ -369,7 +369,7 @@ | |||
| - name: --network-plugin | |||
| type: string | |||
| short-summary: The Kubernetes network plugin to use. | |||
| long-summary: Specify "azure" for advanced networking configurations. Defaults to "kubenet". | |||
| long-summary: Specify "azure" for routable pod IPs from VNET, "kubenet" for non-routable pod IPs with an overlay network, or "none" for no networking configured. Defaults to "kubenet". | |||
There was a problem hiding this comment.
Missing help message update several lines above. Opened another PR #23344 to catch the July release.
|
Replaced by #23344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create --network-plugin noneDescription
Previous valid values for
networkPlugin:kubenet,azureNew valid values for
networkPlugin:kubenet,azure,nonenetwork-plugin=noneenables Bring Your Own CNI (BYOCNI). With this option, no CNI is installed by default.Testing Guide
az aks create --network-plugin noneHistory Notes
[AKS]
az aks create: Add--network-plugin=nonesupport for BYO CNIThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.