[AKS] az aks get-credentials: Fix the command error when KUBECONFIG is empty
#23000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
assigned 
|
AKS |
fseldow
approved these changes
Jun 24, 2022
zhoxing-ms
reviewed
Jun 24, 2022
| logger.info("The default path '%s' is replaced by '%s' defined in KUBECONFIG.", path, kubeconfig_path) | ||
| path = kubeconfig_path | ||
| else: | ||
| logger.warning("Invalid path '%s' defined in KUBECONFIG.", kubeconfig_path) |
There was a problem hiding this comment.
Why just print the warning log instead of raising an exception?
There was a problem hiding this comment.
Personally, I think there are some usage scenarios where the user has multiple kubeconfig files, then sets the environment variable KUBECONFIG to point to a specific kubeconfig file to perform some operatations, and sometimes leaves KUBECONFIG empty to operate with the kubeconfig located in the default path (~/.kube/config).
I hope this change is that when the user sets KUBECONFIG to be empty, the kubeconfig of the cluster can also be successfully downloaded to the default location.
More discussions are welcome：）
zhoxing-ms
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks get-credentialsDescription
When KUBECONFIG is empty, keep using the default storage path (
~/.kube/config) and output warning-level logs; otherwise, use the path in KUBECONFIG to replace the default storage path and output info-level logs. Thanks to @fseldow for reporting this bug.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.