Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network] BREAKING CHANGE: az network vnet subnet create: Disable PrivateEndpointNetworkPolicies by default #22962

Merged
merged 3 commits into from
Jun 28, 2022
Merged

[Network] BREAKING CHANGE: az network vnet subnet create: Disable PrivateEndpointNetworkPolicies by default #22962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a036e28
disable PrivateEndpointNetworkPolicies by default
necusjz Jun 22, 2022
c078633
disable PrivateEndpointNetworkPolicies when creating with vnet
necusjz Jun 28, 2022
9123471
refine help message
necusjz Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/network/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2009,7 +2009,7 @@ def load_arguments(self, _):
c.argument('service_endpoints', nargs='+', min_api='2017-06-01')
c.argument('service_endpoint_policy', nargs='+', min_api='2018-07-01', help='Space-separated list of names or IDs of service endpoint policies to apply.', validator=validate_service_endpoint_policy)
c.argument('delegations', nargs='+', min_api='2017-08-01', help='Space-separated list of services to whom the subnet should be delegated. (e.g. Microsoft.Sql/servers)', validator=validate_delegations)
c.argument('disable_private_endpoint_network_policies', arg_type=get_three_state_flag(), min_api='2019-04-01', help='Disable private endpoint network policies on the subnet.')
c.argument('disable_private_endpoint_network_policies', arg_type=get_three_state_flag(), min_api='2019-04-01', help='Disable private endpoint network policies on the subnet, Disabled by default.')
c.argument('disable_private_link_service_network_policies', arg_type=get_three_state_flag(), min_api='2019-04-01', help='Disable private link service network policies on the subnet.')

with self.argument_context('network vnet subnet create') as c:
Expand Down
3 changes: 2 additions & 1 deletion src/azure-cli/azure/cli/command_modules/network/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6998,6 +6998,7 @@ def create_vnet(cmd, resource_group_name, vnet_name, vnet_prefixes='10.0.0.0/16'
vnet.subnets = [Subnet(name=subnet_name,
address_prefix=subnet_prefix[0] if len(subnet_prefix) == 1 else None,
address_prefixes=subnet_prefix if len(subnet_prefix) > 1 else None,
private_endpoint_network_policies='Disabled',
network_security_group=NetworkSecurityGroup(id=network_security_group)
if network_security_group else None)]
else:
Expand Down Expand Up @@ -7119,7 +7120,7 @@ def create_subnet(cmd, resource_group_name, virtual_network_name, subnet_name,
if delegations:
subnet.delegations = delegations

if disable_private_endpoint_network_policies is True:
if disable_private_endpoint_network_policies is None or disable_private_endpoint_network_policies is True:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change the function signature

disable_private_endpoint_network_policies=True,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some research, the reason why default argument "True" becomes "1", it's a kind of distinguishing:
https://github.com/microsoft/knack/blob/b4d9e66b469ef7c18a1f228f803505b7f550bdc1/knack/commands.py#L122-L124

subnet.private_endpoint_network_policies = "Disabled"
if disable_private_endpoint_network_policies is False:
subnet.private_endpoint_network_policies = "Enabled"
Expand Down
544 changes: 267 additions & 277 deletions ...zure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_vnet.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading