[HDInsight] Migrate adal graph sdk to msgraph sdk in HDInsight module #22503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
aim-for-better
changed the title
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 22503 in repo Azure/azure-cli |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 22503 in repo Azure/azure-cli |
Collaborator
|
HDInsight |
Member
Author
|
Hi team, I find that I can not change the PR title, I added one space to fix the format issue, but after I refersh the page, there is not space. |
Member
|
This is happening again - "Azure.azure-cli Full Test" is not triggered. @wangzelin007 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jiasli
reviewed
May 18, 2022
Comment on lines
+28
to
+29
| from azure.cli.command_modules.role import graph_client_factory | ||
| client = graph_client_factory(cli_ctx) |
Member
There was a problem hiding this comment.
I am glad to see the new azure.cli.command_modules.role.graph_client_factory interface significantly reduces the effort to build a Graph client. 😊
Member
Author
There was a problem hiding this comment.
I am glad to see the new
azure.cli.command_modules.role.graph_client_factoryinterface significantly reduces the effort to build a Graph client. 😊
learnt this from key vault PR 😁
jiasli
approved these changes
May 18, 2022
kairu-ms
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Only two completers are impacted.
Description
This PR migrate ADAL graph SDK to MS graph SDK.
There is not customer impact
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.