Skip to content

Conversation

@necusjz
Copy link
Member

@necusjz necusjz commented May 17, 2022

Related command

Description

Bullet points:

  • Removed "live_only" mentioned in: {Network} Temporarily bypass vwan tests #22485;
  • Fixed "content_type" introduced by 2017-10-01;
  • Temporarily bypass several rdbms tests (@DaeunYim for awareness):
    • test_mysql_flexible_server_georestore_mgmt;
    • test_mysql_flexible_server_restore_mgmt;
    • test_mysql_flexible_server_vnet_mgmt_supplied_subnetid;
    • test_mysql_flexible_server_vnet_mgmt_supplied_subnet_id_in_different_rg;
    • test_mysql_flexible_server_vnet_mgmt_supplied_vname_and_subnetname;
    • test_postgres_flexible_server_vnet_mgmt_supplied_vname_and_subnetname;
    • test_postgres_flexible_server_restore_mgmt;
    • test_mysql_flexible_server_existing_private_dns_zone;
    • test_mysql_flexible_server_new_private_dns_zone;

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

necusjz added 17 commits May 13, 2022 11:34
� Conflicts:
�	src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_control_plane_user_assigned_identity.yaml
�	src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_default_service_with_skip_role_assignment_msi.yaml
�	src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_node_public_ip.yaml
�	src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_slb_vmss_with_outbound_ip_prefixes_then_update_msi.yaml
�	src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_slb_vmss_with_outbound_ip_then_update_msi.yaml
�	src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_create.yaml
�	src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_delete.yaml
�	src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_list.yaml
�	src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_list_credentials.yaml
�	src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_show.yaml
�	src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_update.yaml
�	src/azure-cli/azure/cli/command_modules/eventhubs/tests/latest/recordings/test_eh_network.yaml
�	src/azure-cli/azure/cli/command_modules/eventhubs/tests/latest/recordings/test_eh_privateendpoint.yaml
�	src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_private_endpoint_connection_eventhub.yaml
�	src/azure-cli/requirements.py3.Darwin.txt
�	src/azure-cli/requirements.py3.Linux.txt
�	src/azure-cli/requirements.py3.windows.txt
�	src/azure-cli/setup.py
…twork-sdk

� Conflicts:
�	src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/recordings/test_keyvault_network_rule.yaml
�	src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_image_builder_basic.yaml
@ghost ghost requested review from jsntcy, kairu-ms and yonzhan May 17, 2022 05:36
@ghost ghost added the Auto-Assign Auto assign by bot label May 17, 2022
@ghost ghost requested a review from wangzelin007 May 17, 2022 05:37
@ghost ghost assigned necusjz May 17, 2022
@ghost ghost added this to the May 2022 (2022-05-24) - For Build milestone May 17, 2022
@ghost ghost added the Network az network vnet/lb/nic/dns/etc... label May 17, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented May 17, 2022

Network

necusjz added 3 commits May 17, 2022 20:34
…twork-sdk

� Conflicts:
�	src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_security_partner_provider.yaml
�	src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_private_endpoint_connection_service_bus.yaml
�	src/azure-cli/azure/cli/command_modules/servicebus/tests/latest/recordings/test_sb_network.yaml
@necusjz necusjz changed the title [Network] Bump azure-mgmt-network from 19.3.0 to 20.0.0 {Network} Bump azure-mgmt-network from 19.3.0 to 20.0.0 May 17, 2022
necusjz added 4 commits May 17, 2022 21:20
…twork-sdk

� Conflicts:
�	src/azure-cli/azure/cli/command_modules/backup/tests/latest/recordings/test_backup_restore.yaml
@necusjz necusjz marked this pull request as ready for review May 18, 2022 02:41
@jiasli
Copy link
Member

jiasli commented May 18, 2022

I saw azure_mgmt_network-20.0.0-py3-none-any.whl is smaller than azure_mgmt_network-19.3.0-py2.py3-none-any.whl:

https://pypi.org/project/azure-mgmt-network/20.0.0/#files
image

https://pypi.org/project/azure-mgmt-network/19.3.0/#files
image

This is a good sign for package size!

raise CLIError('cloud name unexpectedly empty')
copy_kwargs = kwargs.copy()
copy_kwargs.pop('self', None)
copy_kwargs.pop('content_type', None)
Copy link
Member

@jiasli jiasli May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a comment here describing why it is needed.

Copy link
Member

@jiasli jiasli May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the signature change of Python SDK methods (Azure/azure-sdk-for-python#24162):

https://github.com/Azure/azure-sdk-for-python/blob/83ff40e58aad2fbd3f912e2f302a342f1e89a1f9/sdk/network/azure-mgmt-network/azure/mgmt/network/v2017_10_01/operations/_operations.py#L22890-L22899

    @distributed_trace
    def begin_create_or_update(
        self,
        resource_group_name: str,
        virtual_network_name: str,
        parameters: "_models.VirtualNetwork",
        *,
        content_type: Optional[str] = "application/json",
        **kwargs: Any
    ) -> LROPoller["_models.VirtualNetwork"]:

To trigger it, run

az cloud set --profile 2018-03-01-hybrid --name AzureCloud
az network vnet update -n clitestvnet3 -g clitest.rgvsrrci2gv23pas67rbcxkq3wi3mlj5wohqb6capbzzu6mnlijgtvkrydqtmes4xth --set enableDdosProtection=true --defer

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network az network vnet/lb/nic/dns/etc...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants