[IoT] Support IoT Hub and DPS Data Residency feature #21348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IoT |
c-ryan-k
requested review from
digimaun,
zhoxing-ms,
jiasli,
evelyn-ys,
jsntcy,
kairu-ms and
calvinhzy
as code owners
|
Looks like some external tests are failing since we updated the default control-plane API-version for hub, will update and push those recordings in a bit |
zhoxing-ms
approved these changes
Feb 18, 2022
digimaun
reviewed
Feb 19, 2022
| VerificationCodeResponse) | ||
| if isinstance(certificate_response, CertificateListDescription) and certificate_response.value: | ||
| for cert in certificate_response.value: | ||
| cert = _replace_certificate_bytes(cert) |
There was a problem hiding this comment.
nit, is this assignment needed?
digimaun
approved these changes
Feb 19, 2022
wangzelin007
approved these changes
Feb 22, 2022
evelyn-ys
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the control-plane SDKs for both IoT Hub and DPS to support new API-versions, as well as a new creation property to enforce data residency on these resources.
Testing Guide
az iot hub|dps create -g resource_group -n iot_hub --enforce-data-residency: Creates an IoT Hub with data-residency enforced (and thereby disabling cross-region disaster recovery).History Notes
[IoT]
az iot hub create: Add the--enforce-data-residencyparameter to support creating resources with data residency enforced (and cross-region disaster recovery disabled).[IoT]
az iot dps create: Add the--enforce-data-residencyparameter to support creating resources with data residency enforced (and cross-region disaster recovery disabled).This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.