Change the automation code #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
troydai
commented
Jan 6, 2017
troydai
commented
- Install automation code as a development package. The outcome is that the automation code can be invoked without add ./scripts folder to the PYTHONPATH.
- Add PEP8 scripts to fix PEP8 automatically
1. Install automation code as development package 2. Add PEP8 scripts to fix PEP8 automatically
tjprescott
reviewed
Jan 6, 2017
| @@ -2,7 +2,6 @@ adal==0.4.3 | |||
| applicationinsights==0.10.0 | |||
| argcomplete==1.3.0 | |||
| colorama==0.3.7 | |||
| coverage==4.2 | |||
There was a problem hiding this comment.
Why are we removing this dependency?
There was a problem hiding this comment.
It is moved to automation package's setup.py.
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| def fix_pip8(directory): |
There was a problem hiding this comment.
typo: should be fix_pep8. Also, where does it "fit" (i.e. how and when will we invoke it?) Should it be added to the CI scripts?
There was a problem hiding this comment.
- I'll fix the typo;
- I don't think this should be added to the CI script. From what I saw the autopep8 doesn't fix everything perfectly. It needs human intervention.
- What I do plan to add is a PEP8 code style check run after pylint.
|
Looks good? I'll merge soon. |
derekbekoe
reviewed
Jan 6, 2017
| ] | ||
|
|
||
| setup( | ||
| name='automation', |
There was a problem hiding this comment.
As discussed, please change name as even though we won't be releasing this package, it conflicts with https://pypi.python.org/pypi/automation.
There was a problem hiding this comment.
I'll fix this right now.
thegalah
pushed a commit
to thegalah/azure-cli
that referenced
this pull request
Jan 6, 2017
* Azure/master: Release azure-cli-component 0.1.0b12 (Azure#1665) Rename the utility automation package name (Azure#1664) [ACS] Update service principal creation so that it is subscription specific. (Azure#1630) Change the automation code (Azure#1660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.