Fix blob type validator #1656
Merged
Fix blob type validator #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troydai
reviewed
Jan 5, 2017
| @@ -122,7 +122,8 @@ def validate_source_uri(namespace): | |||
| namespace.copy_source = uri | |||
|
|
|||
| def validate_blob_type(namespace): | |||
| namespace.blob_type = 'page' if namespace.file_path.endswith('.vhd') else 'block' | |||
| if namespace.blob_type is None: | |||
There was a problem hiding this comment.
use if not namespace.blob_type instead of is None
|
To fix the error, it looks like you need to re-record the blob scenario test. In the storage test recordings delete the |
tjprescott
approved these changes
Jan 5, 2017
thegalah
pushed a commit
to thegalah/azure-cli
that referenced
this pull request
Jan 6, 2017
* Azure/master: Fix PEP8 for azure-cli (Azure#1661) [VM/VMSS] Enable Multi-Cloud VM/VMSS Create (Azure#1654) Fix blob type validator (Azure#1656) Improve @file handling logic (Azure#1648) Name private_config.json differently in VM test (Azure#1653) Update regex of parsing sdk function argument comments (Azure#1650) Reorganize test run in automation (Azure#1624) Fix issue 1644. (Azure#1647) [Network] VNet Gateway Fixes and Enhancements (Azure#1643) [Network] Application Gateway Commands and Fixes (Azure#1606) [Docs] Correcting unittest location in docs (Azure#1642) [ACS] Add a table transform for acs show to match acs list. (Azure#1641) [ACS] Add a unit test and fix a bug with az browse ... (Azure#1640) [Component] Fix pip seg fault on 'az component update' (Azure#1639) fixed typo (Azure#1634)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blob_type cannot be set to
appendbecause of this validator, such as inaz storage blob uploadcommand by--typeargument.