[Network] Fix Networking command issues and refactor folded arguments #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
added
Breaking Change
bug
|
@tjprescott, thanks for your PR! By analyzing the history of the files in this pull request, we identified @derekbekoe, @BurtBiel and @yugangw-msft to be potential reviewers. |
tjprescott
changed the title
| help_text = 'Name or ID of an existing {}.'.format(display_name) | ||
| elif not allow_new and allow_none and not default_none: | ||
| help_text = 'Name or ID of an existing {}, or {} for none.'.format(display_name, quotes) | ||
| elif allow_new and not allow_none and not default_none: |
There was a problem hiding this comment.
and not default_none is not needed, as the first if block has excluded this case already.
| # if a parent name was required but not specified, raise a usage error | ||
| if has_parent and not value_was_id and not parent_val and not allow_new: | ||
| raise ValueError('incorrect usage: {} ID | {} NAME {} NAME'.format( | ||
| property_option, property_option, parent_option)) |
There was a problem hiding this comment.
you can use 'incorrect usage: {0} ID | {0} NAME ... to save an occurrence of property_option
| raise argparse.ArgumentError( | ||
| None, 'Must specify a subnet OR a public IP address, not both.') | ||
| raise ValueError( | ||
| 'incorrect usage: --subnet NAME_OR_ID [--vnet-name NAME] | --public-ip NAME_OR_ID') |
There was a problem hiding this comment.
Should it be 'incorrect usage: --subnet NAME --vnet-name NAME | --subnet ID | --public-ip NAME_OR_ID?
There was a problem hiding this comment.
Yes, I like that even better.
|
|
||
| if namespace.subnet and namespace.public_ip_address: | ||
| raise ValueError( | ||
| 'incorrect usage: --subnet NAME_OR_ID [--vnet-name NAME] | --public-ip NAME_OR_ID') |
| headers: | ||
| Accept: [application/json] | ||
| Accept-Encoding: ['gzip, deflate'] | ||
| Authorization: [Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6IlJyUXF1OXJ5ZEJWUldtY29jdVhVYjIwSEdSTSIsImtpZCI6IlJyUXF1OXJ5ZEJWUldtY29jdVhVYjIwSEdSTSJ9.eyJhdWQiOiJodHRwczovL21hbmFnZW1lbnQuY29yZS53aW5kb3dzLm5ldC8iLCJpc3MiOiJodHRwczovL3N0cy53aW5kb3dzLm5ldC81NDgyNmIyMi0zOGQ2LTRmYjItYmFkOS1iN2I5M2EzZTljNWEvIiwiaWF0IjoxNDc5NDg4Nzg5LCJuYmYiOjE0Nzk0ODg3ODksImV4cCI6MTQ3OTQ5MjY4OSwiYWNyIjoiMSIsImFtciI6WyJwd2QiXSwiYXBwaWQiOiIwNGIwNzc5NS04ZGRiLTQ2MWEtYmJlZS0wMmY5ZTFiZjdiNDYiLCJhcHBpZGFjciI6IjAiLCJlX2V4cCI6MTA4MDAsImZhbWlseV9uYW1lIjoiQWRtaW4yIiwiZ2l2ZW5fbmFtZSI6IkFkbWluMiIsImdyb3VwcyI6WyJlNGJiMGI1Ni0xMDE0LTQwZjgtODhhYi0zZDhhOGNiMGUwODYiLCI2Yjk3NzYxYS1kN2QwLTQ4ZjYtYWQ1Ni1mMzhkMzI3Yzg1NTMiXSwiaXBhZGRyIjoiMTY3LjIyMC4wLjE4NiIsIm5hbWUiOiJBZG1pbjIiLCJvaWQiOiI1OTYzZjUwYy03YzQzLTQwNWMtYWY3ZS01MzI5NGRlNzZhYmQiLCJwbGF0ZiI6IjE0IiwicHVpZCI6IjEwMDNCRkZEOTU5Rjg0MjMiLCJzY3AiOiJ1c2VyX2ltcGVyc29uYXRpb24iLCJzdWIiOiJzRGdleFJ3Q05JZlktaHpRampDRHZaVDdJemRmbzRTeXJyNHgwZEROelI0IiwidGlkIjoiNTQ4MjZiMjItMzhkNi00ZmIyLWJhZDktYjdiOTNhM2U5YzVhIiwidW5pcXVlX25hbWUiOiJhZG1pbjJAQXp1cmVTREtUZWFtLm9ubWljcm9zb2Z0LmNvbSIsInVwbiI6ImFkbWluMkBBenVyZVNES1RlYW0ub25taWNyb3NvZnQuY29tIiwidmVyIjoiMS4wIiwid2lkcyI6WyI2MmU5MDM5NC02OWY1LTQyMzctOTE5MC0wMTIxNzcxNDVlMTAiXX0.ByWZCGTYEoUyY8abc1y-td4_jraXQzd9hTEj6QPB31ZB87OHRaCFM204G6xSgGJfi-TrjS7nTS9JYBGIQUnJwjghZEPLgacjO-YxAo2gYMMLEHsT-r3wnh3MMxsJvNZg0VffXDIbSVl3B23_QiNJ-vUmfFVGeMwuNDArhTMzII4P-o4dzmr3As_pL1qR_6ZBcYrPZO7iQtfc_4zvu_a_1_XUoHIbq9gT-_xYWIMNJ5tTkuEBf26K4CMB7fJLEC5U19AVme8lySwzFUtZJs9pF7icAfUBZIyttjPp1yc15nuck1LBjiWE68LrDfNAw1DfACkKgKV2kjseVXWCiPV3TQ] |
haroldrandom
added
Breaking Change
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1237, fixes #1238, fixes #920
Replaces instances of
register_folded_cli_argumentin the network module with simpler solutions. Overall, improves the help and validation of the affected parameters while also simplifying the heavily parameterized logic of the oldregister_folded_cli_argument. Once the VM module is refactored,register_folder_cli_argumentwill be removed.Also:
dump_command_table.pyscript to work with the recent perf improvements.