-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account: dump extra information on account or newly created service principal #1364
Conversation
ecf2f80
to
6d099c7
Compare
6d099c7
to
367097b
Compare
az account show --expanded-view
{
"endpoints": {
"activeDirectory": "https://login.microsoftonline.com",
"activeDirectoryGraphResourceId": "https://graph.windows.net/",
"activeDirectoryResourceId": "https://management.core.windows.net/",
"gallery": "https://gallery.azure.com/",
"management": "https://management.core.windows.net/",
"resourceManager": "https://management.azure.com/",
"sqlManagement": "https://management.core.windows.net:8443/"
},
"environmentName": "AzureCloud",
"id": "a7d7a534-7494-4099-8350-b44e96c5xxxx",
"name": "https://yugangwlogin",
"password": "VerySecret-xxxxx",
"tenantId": "26833e2e-ee80-4a9d-b24c-ffe135b7xxxx"
} |
//cc:@derekbekoe @jianghaolu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the Profile import?
Apart from that, LGTM!
@@ -11,6 +11,7 @@ | |||
import dateutil.parser | |||
|
|||
from azure.cli.core._util import CLIError, todict, get_file_json | |||
from azure.cli.core._profile import Profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For perf. reasons, can we move this import to inside the method it's used in.
importing Profile was v. slow in my experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI on importing Profile:
$ time python -c 'from azure.cli.core._profile import Profile'
real 0m0.446s
user 0m0.364s
sys 0m0.080s
Per ask from java sdk team. Fix #1097. I updated some naming so this whole thing won't look odd.
Once we are fine with the change, i will add one test