Add az acs kubernetes browse and also open a web browser.
#1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be an awesome helper command. Thanks for the quick response! |
brendandburns
force-pushed
the
browse
branch
from
c2aeb62 to
460838d
Compare
derekbekoe
reviewed
Nov 16, 2016
| """ | ||
| Wrapper on the 'kubectl proxy' command, for consistency with 'az dcos brows' | ||
| """ | ||
| logger.info('Proxy running on 127.0.0.1:8001/ui') |
There was a problem hiding this comment.
This should be logger.warning I believe.
logger.info will only be should to the user if they add the --verbose or --debug flags.
|
|
||
| def k8s_browse(disable_browser=False): | ||
| """ | ||
| Wrapper on the 'kubectl proxy' command, for consistency with 'az dcos brows' |
| t.daemon = True | ||
| t.start() | ||
|
|
||
| def k8s_browse(disable_browser=False): |
There was a problem hiding this comment.
Should add help for the disable_browser param.
You can modify _params.py. Could add something like this:
register_cli_argument('acs', 'disable_browser', help='Do not open browser after command execution')
There was a problem hiding this comment.
By passing in the first argument as 'acs', it'll add help for the DCOS browse command below as well.
| @@ -61,6 +87,8 @@ def dcos_browse(name, resource_group_name): | |||
| proxy.set_http_proxy('127.0.0.1', local_port) | |||
| logger.info('Proxy running on 127.0.0.1:%s', local_port) | |||
There was a problem hiding this comment.
This should be warning instead of info also.
brendandburns
force-pushed
the
browse
branch
from
460838d to
e47b96f
Compare
thegalah
pushed a commit
to thegalah/azure-cli
that referenced
this pull request
Nov 17, 2016
* Azure/master: Add `az acs kubernetes browse` and also open a web browser. (Azure#1327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1321
@lostintangent