[Network] Fix Network Bugs 1239, 1240 #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
changed the title
yugangw-msft
approved these changes
Nov 9, 2016
| @@ -63,7 +63,9 @@ def delete_func(resource_group_name, resource_name, item_name): | |||
| keep_items = \ | |||
| [x for x in item.__getattribute__(prop) if x.name.lower() != item_name.lower()] | |||
| _set_param(item, prop, keep_items) | |||
| return client.create_or_update(resource_group_name, resource_name, item) | |||
| result = client.create_or_update(resource_group_name, resource_name, item).result() | |||
| if next((x for x in getattr(result, prop) if x.name == item_name), None): | |||
There was a problem hiding this comment.
Please consider whether the item_name could have casing difference. If yes, do case insensitive comparison
|
@yugangw-msft I made the case insensitive comparison and fixed up the VS project file for the perf change PR. I plan to merge once CI finishes. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239, fixes #1240.
Plan to defer merging this until #1059 is merged.