Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for acr command module #1269

Merged
merged 1 commit into from
Nov 9, 2016
Merged

Conversation

djyou
Copy link
Member

@djyou djyou commented Nov 8, 2016

To address issue #1201

@djyou
Copy link
Member Author

djyou commented Nov 8, 2016

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I'd mention is that the ResourceGroupVCRTestBase will automatically delete the resource group after the test finishes which should take care of the two storage accounts.

@djyou
Copy link
Member Author

djyou commented Nov 9, 2016

@tjprescott Can we merge and close this issue #1201?

@tjprescott
Copy link
Member

@djyou we just merged a major PR. Would you please rebase your PR and after the CI runs I'll gladly merge it. It looks like it should rebase fine.

@djyou
Copy link
Member Author

djyou commented Nov 9, 2016

@tjprescott Done, thanks for the heads up.

@tjprescott tjprescott merged commit fc8e9cd into Azure:master Nov 9, 2016
@djyou djyou deleted the doyou/tests branch November 9, 2016 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants