adal:upgrade to 0.4.2 #1225
Merged
adal:upgrade to 0.4.2 #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//cc @derekbekoe |
yugangw-msft
commented
Nov 3, 2016
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| LOGIN_METHOD_LIST = [ | |||
| 'Device code authentication, we will provide a code you enter into a web page and log into', | |||
| 'Username and password', | |||
| "Username and password(won't work for MFA enforced accounts or MSA accounts such as live-id)", | |||
There was a problem hiding this comment.
@derekbekoe, this is the message I updated per clarification towards a user inquiry
There was a problem hiding this comment.
- Instead of
won't work for ..., would suggestMFA enforced accounts or MSA accounts such as live-id not supported. - nit: add a space before the ( like below.
derekbekoe
approved these changes
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1086